-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Dynamic coin change implemented #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic coin change implemented #280
Conversation
kolosovpetro
commented
Jan 7, 2022
- I have performed a self-review of my code
- My code follows the style guidelines of this project
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- Comments in areas I changed are up to date
- I have added comments to hard-to-understand areas of my code
- I have made corresponding changes to the README.md
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
+ Coverage 94.97% 95.11% +0.13%
==========================================
Files 158 159 +1
Lines 7581 7670 +89
==========================================
+ Hits 7200 7295 +95
+ Misses 381 375 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, please add some comments explaining what methods do
Algorithms.Tests/Problems/CoinChange/Dynamic/GenerateSingleCoinChangesTests.cs
Outdated
Show resolved
Hide resolved
Algorithms.Tests/Problems/CoinChange/Dynamic/GenerateSingleCoinChangesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only minor suggestions
Algorithms.Tests/Problems/CoinChange/Dynamic/GenerateSingleCoinChangesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!