[BUG] <Issue in Herons Formula> #4685
Assignees
Labels
Comments
5 tasks
5 tasks
|
I want to interested to contribute can you assigned me. |
|
Hey i just got a solution for this issue in which a function need to work for various data types . Please Assign me this issue so that i can quickly solve this by Function Overloading. |
justharshal2023
added a commit
to justharshal2023/Java
that referenced
this issue
Oct 6, 2023
Fixes TheAlgorithms#4685 -Changes: 1.herons formula parameters changed to double to calculate area 2.Added triangle validation condition I have read CONTRIBUTING.md. This pull request is all my own work -- I have not plagiarized it. All filenames are in PascalCase. All functions and variable names follow Java naming conventions. All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
|
Can you assign me this issue? |
|
Hey @satyabarghav if this issue is still unsolved then please feel free to assign me this issue i have already solved it in my fork using function overloading please check |
|
Hey @satyabarghav if this issue is still unsolved then please feel free to assign me this issue |
|
hey @satyabarghav can you assign me this issue |
|
Closed by #4686. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Description
In the implementation of Herons Formula we have the signature of the function as Herons(int a, int b, int c) so when we call the function we are confined to only integer inputs and we will get the error when using sides of double or float data type
Excepted behavior
So we need to change the signature of the function to even work with data types of even double or float.
I have attached the error we get while calling the function with parameters of double data type.
Screenshots
The text was updated successfully, but these errors were encountered: