Herons : Changed the signature of the function #4686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #4685 |
5f4f5d5 to
2df4690
Compare
5 tasks
vil02
requested changes
Oct 21, 2023
|
Fixes #4685. |
22724b5 to
86f96c4
Compare
|
Made the requested changes, I request the Reviewer(s) to please tag this as hacktoberfest-accepted. |
vil02
requested changes
Oct 22, 2023
5840c3e to
383146b
Compare
vil02
requested changes
Oct 22, 2023
vil02
reviewed
Oct 22, 2023
This is not needed, since this repository has |
|
@satyabarghav there was a subtle error in the check if all of the provided sidelights are positive, namely, the tests: Assertions.assertThrows(IllegalArgumentException.class, () -> { HeronsFormula.herons(1, 1, 0); });
Assertions.assertThrows(IllegalArgumentException.class, () -> { HeronsFormula.herons(1, 0, 1); });
Assertions.assertThrows(IllegalArgumentException.class, () -> { HeronsFormula.herons(0, 1, 1); });did not pass. Always add tests. To speed up the whole process I allowed myself to push a commit into your branch - I hope you do not mind. |
vil02
approved these changes
Oct 23, 2023
|
Cool, thanks for being with me :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have already raised this issue here
The required changes were made to make it work with even larger set of data types like double and float and further documentation was also added ro ease the readability and understandability of the code.