Skip to content

Fix update dir job #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2022
Merged

Fix update dir job #3157

merged 3 commits into from
Jun 22, 2022

Conversation

Boiarshinov
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

#3155

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Boiarshinov Boiarshinov mentioned this pull request Jun 21, 2022
Closed
Boiarshinov
Boiarshinov commented Jun 21, 2022
View reviewed changes
@Boiarshinov
Copy link
Contributor Author

Now update dir is working well but the build job failed.
It seems that it failed because of flacky tests. And these tests is by my authorship, sorry. Skip list is a probabilistic data structure so the internal structure is not deterministic so test could pass in one build and failed in another without any changes of code. I will try to find a bug and fix it in a separate PR

@Boiarshinov
Copy link
Contributor Author

Here is a PR with the fix of failed tests: #3160

@yanglbme yanglbme merged commit a910d87 into TheAlgorithms:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme yanglbme approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Boiarshinov @yanglbme