Fix SkipList remove operation #3160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
References
There was a failed build: https://github.com/TheAlgorithms/Java/runs/6992142297?check_suite_focus=true
After some debugging I have found the problem. After removing some node all links for previous and next node should be reassigned. But current algorithm did not mentioned that next node could be null. For example (on this structure tests had failed in linked build):
When we try to delete node with index 0, it would have null next nodes on layers 4 and 5.
I had fixed an issue and add test case with removing last node. So removing elements with pointers to null is tested separately now.
Checklist:
Fixes: #{$ISSUE_NO}
.