-
Notifications
You must be signed in to change notification settings - Fork 20.1k
Update maths/Volume.java #3773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maths/Volume.java #3773
Conversation
shitkoder
commented
Nov 19, 2022
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized it.
- All filenames are in PascalCase.
- All functions and variable names follow Java naming conventions.
- All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please fix the build check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ellipsoid Volume formula is wrong
https://www.omnicalculator.com/math/ellipsoid-volume#:~:text=Volume%20%3D%204/3%20*%20%CF%80%20*%20A%20*%20B%20*%20C%2C
Check this, change the code, and test accordingly.
Co-authored-by: Debasish Biswas <debasishbsws.abc@gmail.com>
I am unable to find where the build check is failing. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It says |