Skip to content

Update maths/Volume.java #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

shitkoder
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix the build check.

Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ellipsoid Volume formula is wrong
https://www.omnicalculator.com/math/ellipsoid-volume#:~:text=Volume%20%3D%204/3%20*%20%CF%80%20*%20A%20*%20B%20*%20C%2C

Check this, change the code, and test accordingly.

Co-authored-by: Debasish Biswas <debasishbsws.abc@gmail.com>
@shitkoder
Copy link
Contributor Author

Looks good. Please fix the build check.

I am unable to find where the build check is failing.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 23, 2022
@siriak
Copy link
Member

siriak commented Dec 24, 2022

It says
Error: COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error: /home/runner/work/Java/Java/src/main/java/com/thealgorithms/maths/Volume.java:[98,63] illegal start of type
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.021 s
[INFO] Finished at: 2022-11-20T14:33:13Z
[INFO] ------------------------------------------------------------------------
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project Java: Compilation failure
Error: /home/runner/work/Java/Java/src/main/java/com/thealgorithms/maths/Volume.java:[98,63] illegal start of type
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error: Process completed with exit code 1.

@github-actions github-actions bot removed the stale label Dec 25, 2022
@shitkoder shitkoder closed this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants