added Highest Set Bit algo #4330

BamaCharanChhandogi · 2023-08-25T07:50:03Z

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java

src/test/java/com/thealgorithms/bitmanipulation/HighestSetBitTest.java

BamaCharanChhandogi · 2023-08-28T01:31:48Z

If I do this
// Handle negative numbers by converting to their absolute value
if (num < 0) {
num = Math.abs(num);
}

OR(No negative number allow)

if(num<=0){
return -1;
}

vil02

To handle 0 as an input, I would suggest to use the Optional, i.e. to rewrite this class into something like that:

import java.util.Optional;

public final class HighestSetBit {
    private HighestSetBit() {
    }

    public final static Optional<Integer> findHighestSetBit(int num) {
        if (num < 0) {
            throw new IllegalArgumentException("Input cannot be negative");
        }
        
        if (num == 0) {
            return Optional.empty();
        }
        
        int position = 0;
        while (num > 0) {
            num >>= 1;
            position++;
        }
    
        return Optional.of(position - 1);
    }
}

Please note that this will requite updating the tests.

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java

BamaCharanChhandogi · 2023-08-28T20:49:13Z

It is a good idea but I think here -1 represents there are no index of highest set bit.
if you say to do this yeah I will do it.

vil02 · 2023-08-28T20:59:15Z

It is a good idea but I think here -1 represents there are no index of highest set bit. if you say to do this yeah I will do it.

Well you need to somehow document that or agree that the index -1 means that there is no such bit. In my opinion using Optional here requires less documentation.
@siriak what do you think?

@BamaCharanChhandogi I would still insist on this suggestion.

BamaCharanChhandogi · 2023-08-30T20:19:39Z

hey @vil02! Can you check?

src/test/java/com/thealgorithms/bitmanipulation/HighestSetBitTest.java

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java

vil02

Regarding the code: looks good to me.

I am not sure about the doc-strings (which tags to use etc.). I would add some explanation of what HighestSetBit really does (e.g. that we count from right to left). I think it is also worth to mention that this algorithm assumes that the int is big endian.

src/test/java/com/thealgorithms/bitmanipulation/HighestSetBitTest.java

siriak · 2023-09-02T19:48:26Z

@vil02 please review again and resolve comments.

P.S.
@vil02 could you add me in Discord or email me? I'd like to chat with you but cannot find any contact information

vil02

The code and the tests look good.

Please rebase before the merging: after having #4343, newline symbols at the end of each file are required.

@siriak please comment on the doc-strings.

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java

src/test/java/com/thealgorithms/bitmanipulation/HighestSetBitTest.java

siriak

@vil02 please review

siriak

I think the current description of the algorithm is adequate and intuitively clear. We don't need to complicate it with further clarifications about endianness.

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java

BamaCharanChhandogi · 2023-09-05T09:52:35Z

@siriak Check!

added Highest Set Bit algo

923a015

BamaCharanChhandogi requested review from siriak, yanglbme, debasishbsws and albina-astr as code owners August 25, 2023 07:50

uvcourses approved these changes Aug 25, 2023

View reviewed changes

siriak reviewed Aug 26, 2023

View reviewed changes

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java Outdated Show resolved Hide resolved

src/test/java/com/thealgorithms/bitmanipulation/HighestSetBitTest.java Show resolved Hide resolved

BamaCharanChhandogi added 2 commits August 27, 2023 02:01

solved some issue

ef2801f

linter solved

b05992b

BamaCharanChhandogi added 5 commits August 29, 2023 01:30

add negative number test case

1717f35

linter solved

73db001

linter solved2

26126c6

linter solved3

ac35530

linter solved4

095f22b

vil02 requested changes Aug 28, 2023

View reviewed changes

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java Outdated Show resolved Hide resolved

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java Outdated Show resolved Hide resolved

BamaCharanChhandogi added 2 commits August 31, 2023 01:37

change code for efficient

51e93f9

linter solve

8b5c7c7

BamaCharanChhandogi force-pushed the HighestSetBit branch from b98f8c2 to 8b5c7c7 Compare August 30, 2023 20:16

linter solve2

ec8e63e

vil02 requested changes Aug 30, 2023

View reviewed changes

add get method

9155b7e

siriak requested a review from vil02 August 31, 2023 15:25

vil02 approved these changes Aug 31, 2023

View reviewed changes

src/test/java/com/thealgorithms/bitmanipulation/HighestSetBitTest.java Show resolved Hide resolved

BamaCharanChhandogi added 2 commits August 31, 2023 23:49

added test cases

5319a52

add remaining test cases

6f1995d

vil02 reviewed Aug 31, 2023

View reviewed changes

src/test/java/com/thealgorithms/bitmanipulation/HighestSetBitTest.java Show resolved Hide resolved

vil02 mentioned this pull request Aug 31, 2023

chore: enforce InsertNewlineAtEOF in clang-format #4343

Merged

5 tasks

last commit

5d1ac83

vil02 requested changes Sep 2, 2023

View reviewed changes

clang formater solved

e9580a3

BamaCharanChhandogi force-pushed the HighestSetBit branch from c96791d to e9580a3 Compare September 2, 2023 20:49

clang formater solved

f5cc5f4

siriak approved these changes Sep 4, 2023

View reviewed changes

siriak reviewed Sep 4, 2023

View reviewed changes

siriak previously approved these changes Sep 4, 2023

View reviewed changes

vil02 reviewed Sep 4, 2023

View reviewed changes

src/main/java/com/thealgorithms/bitmanipulation/HighestSetBit.java Outdated Show resolved Hide resolved

documentation correct

3c234f3

BamaCharanChhandogi dismissed siriak’s stale review via 3c234f3 September 4, 2023 20:50

vil02 approved these changes Sep 4, 2023

View reviewed changes

siriak approved these changes Sep 5, 2023

View reviewed changes

siriak enabled auto-merge (squash) September 5, 2023 20:17

Merge branch 'master' into HighestSetBit

7e13127

siriak merged commit fc693e8 into TheAlgorithms:master Sep 5, 2023

added Highest Set Bit algo #4330

added Highest Set Bit algo #4330

Uh oh!

Conversation

BamaCharanChhandogi commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BamaCharanChhandogi commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vil02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BamaCharanChhandogi commented Aug 28, 2023

Uh oh!

vil02 commented Aug 28, 2023

Uh oh!

BamaCharanChhandogi commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vil02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

siriak commented Sep 2, 2023

Uh oh!

vil02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siriak left a comment

Choose a reason for hiding this comment

Uh oh!

siriak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BamaCharanChhandogi commented Sep 5, 2023

Uh oh!

Uh oh!

BamaCharanChhandogi commented Aug 25, 2023 •

edited

Loading

BamaCharanChhandogi commented Aug 28, 2023 •

edited

Loading

BamaCharanChhandogi commented Aug 30, 2023 •

edited

Loading