Skip to content

chore: enforce InsertNewlineAtEOF in clang-format #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 1, 2023
Merged

chore: enforce InsertNewlineAtEOF in clang-format #4343

merged 5 commits into from
Sep 1, 2023

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Aug 31, 2023 •
edited
Loading

This PR updates the clang-format config to insert the newline symbol at the end of each source file (cf. comment by @siriak ).

Please note that InsertNewlineAtEOF requires clang-format-16 (cf. 02a2cb8). Currently gitpod uses clang-format-14 (update it not so trivial).

d8f99b2 was obtained by running (with having the updated .clang-format )

find . -name "*.java" -exec clang-format-16 -style=file -i {} \;
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@vil02 vil02 marked this pull request as ready for review August 31, 2023 19:58
debasishbsws
debasishbsws approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup It was needed thanks. Looks good to me.

@debasishbsws debasishbsws enabled auto-merge (squash) September 1, 2023 04:09
@debasishbsws debasishbsws merged commit f010a47 into TheAlgorithms:master Sep 1, 2023
@vil02 vil02 deleted the use_InsertNewlineAtEOF_in_clang_format branch September 1, 2023 16:11
This was referenced Sep 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debasishbsws debasishbsws debasishbsws approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@albina-astr albina-astr Awaiting requested review from albina-astr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @debasishbsws