Skip to content

Added MapReduce Algorithm in Misc Folder. #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 25, 2023
Merged

Added MapReduce Algorithm in Misc Folder. #4828

merged 6 commits into from
Oct 25, 2023

Conversation

aakiliqbal
Copy link
Contributor

@aakiliqbal aakiliqbal commented Oct 17, 2023 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@aakiliqbal aakiliqbal marked this pull request as ready for review October 17, 2023 15:10
BamaCharanChhandogi
BamaCharanChhandogi reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @aakiliqbal,
You have to create another function for this operation. Next, remove the main method and then add test cases.
You can understand this:
https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/backtracking/ArrayCombination.java
https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/ArrayCombinationTest.java

@aakiliqbal
Copy link
Contributor Author

Hello @aakiliqbal, You have to create another function for this operation. Next, remove the main method and then add test cases. You can understand this: https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/backtracking/ArrayCombination.java https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/ArrayCombinationTest.java

Hey @BamaCharanChhandogi Thanks for the reply, Ok Sure.

@aakiliqbal
Copy link
Contributor Author

Hey, @BamaCharanChhandogi Can you review my code? I have removed the main method and put my main code in MapReduce function along with some test cases in MapReduceTest.

BamaCharanChhandogi
BamaCharanChhandogi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks.

@BamaCharanChhandogi BamaCharanChhandogi merged commit a4711d6 into TheAlgorithms:master Oct 25, 2023
@aakiliqbal
Copy link
Contributor Author

Thanks @BamaCharanChhandogi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BamaCharanChhandogi BamaCharanChhandogi BamaCharanChhandogi approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aakiliqbal @BamaCharanChhandogi