-
Notifications
You must be signed in to change notification settings - Fork 20k
Parameterize references to generic types. #5078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert all of the changes in the doc-strings - they are out of scope of this PR and we do not have a fixed style of them.
src/main/java/com/thealgorithms/datastructures/dynamicarray/DynamicArray.java
Outdated
Show resolved
Hide resolved
src/main/java/com/thealgorithms/datastructures/lists/CircleLinkedList.java
Outdated
Show resolved
Hide resolved
Well, the doc-strings were automatedly formatted by the Java Extension and it follow the best practices of a Java doc-string. Although, the doc-string changes are out of the scope of this PR, I think this is good and be an enhancement for code readability. However, if these changes are considered out of scope, I am willing to revert them. Please confirm if I should proceed with this action. |
Then please deactivate this Java Extension. As I said before: this repository does not have any fixed and defined style of doc comments. Introducing a new style in few files, would only make the things more messy. |
Thanks for your clarification. I have reverted doc-strings as you requested. |
In this PR, I have solved the problem in Java implementation that related to parameterize references to generic types by adding types to generic containers references.
clang-format -i --style=file path/to/your/file.java