Skip to content

Parameterize references to generic types. #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Parameterize references to generic types. #5078

merged 6 commits into from
Mar 15, 2024

Conversation

sozelfist
Copy link
Contributor

In this PR, I have solved the problem in Java implementation that related to parameterize references to generic types by adding types to generic containers references.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all of the changes in the doc-strings - they are out of scope of this PR and we do not have a fixed style of them.

@sozelfist
Copy link
Contributor Author

sozelfist commented Mar 15, 2024

Please revert all of the changes in the doc-strings - they are out of scope of this PR and we do not have a fixed style of them.

Well, the doc-strings were automatedly formatted by the Java Extension and it follow the best practices of a Java doc-string. Although, the doc-string changes are out of the scope of this PR, I think this is good and be an enhancement for code readability.

However, if these changes are considered out of scope, I am willing to revert them. Please confirm if I should proceed with this action.

@vil02
Copy link
Member

vil02 commented Mar 15, 2024

Please revert all of the changes in the doc-strings - they are out of scope of this PR and we do not have a fixed style of them.

Well, I see that the doc-strings were automatedly formatted by the Java Extension and it follow the best practices of a Java Docstring. Although, the doc-string changes are out of the scope of this PR, I think this is good and look better for code readability.

Then please deactivate this Java Extension. As I said before: this repository does not have any fixed and defined style of doc comments. Introducing a new style in few files, would only make the things more messy.

@sozelfist
Copy link
Contributor Author

Please revert all of the changes in the doc-strings - they are out of scope of this PR and we do not have a fixed style of them.

Well, I see that the doc-strings were automatedly formatted by the Java Extension and it follow the best practices of a Java Docstring. Although, the doc-string changes are out of the scope of this PR, I think this is good and look better for code readability.

Then please deactivate this Java Extension. As I said before: this repository does not have any fixed and defined style of doc comments. Introducing a new style in few files, would only make the things more messy.

Thanks for your clarification. I have reverted doc-strings as you requested.

@sozelfist sozelfist requested a review from vil02 March 15, 2024 17:54
@vil02 vil02 merged commit 192427a into TheAlgorithms:master Mar 15, 2024
@sozelfist sozelfist deleted the fix/minor-changes branch March 15, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants