Skip to content

feat: recursion subsets added #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 2, 2024
Merged

feat: recursion subsets added #5503

merged 15 commits into from
Oct 2, 2024

Conversation

Tuhinm2002
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.59%. Comparing base (e493eb2) to head (0d202a6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...a/com/thealgorithms/Recursion/GenerateSubsets.java 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5503      +/-   ##
============================================
- Coverage     52.59%   52.59%   -0.01%     
- Complexity     3285     3287       +2     
============================================
  Files           527      528       +1     
  Lines         15312    15324      +12     
  Branches       2913     2913              
============================================
+ Hits           8054     8060       +6     
- Misses         6928     6932       +4     
- Partials        330      332       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

siriak
siriak requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove main, make the function return result instead of changing its parameter, give descriptive names to function parameters, add more test cases, and fix PR checks (build and formatter)

@Tuhinm2002
Copy link
Contributor Author

Tuhinm2002 commented Oct 2, 2024 •
edited
Loading

Please remove main, make the function return result instead of changing its parameter, give descriptive names to function parameters, add more test cases, and fix PR checks (build and formatter)

Hey I made the necessary changes and passed all checks now you can merge it

siriak
siriak reviewed Oct 2, 2024
View reviewed changes
siriak
siriak approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 2, 2024 18:49
@siriak siriak merged commit 013d122 into TheAlgorithms:master Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tuhinm2002 @codecov-commenter @siriak