Djikstra optimized #933
Djikstra optimized #933
Conversation
| q.add(sv); | ||
| int n=edges.length; | ||
| visited[sv]=true; | ||
| String s=new String(); |
There was a problem hiding this comment.
Our static analysis engine detects that your pull request includes a change that method invokes inefficient new String() constructor. According to the best practice, creating a new java.lang.String object using the no-argument constructor wastes memory because the object so created will be functionally indistinguishable from the empty string constant "". Java guarantees that identical string constants will be represented by the same String object. Therefore, you should just use the empty string constant directly.
| @@ -0,0 +1,46 @@ | |||
| import java.util.*; | |||
|
|
|||
| public class DFS { | |||
There was a problem hiding this comment.
Please make separate PRs for unrelated codes.
| @@ -0,0 +1,47 @@ | |||
| import java.util.*; | |||
|
|
|||
| public class BFSs { | |||
There was a problem hiding this comment.
Please make separate PRs for unrelated codes.
| return min; | ||
| } | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
Try not to use this approach of having
public static void main(String[] args) {...}call your actual method.
Instead create your class while keeping in mind of how others will use this i.e. by creating objects and calling your actual methods. So make your methods
public <return-type> methodName()Please make this changes.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
As of errors stated in #560 . The issue related solved with code optimization