-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Test cases project euler 9 #1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases project euler 9 #1571
Conversation
…hrown error in case of invalid input
Added |
Could you make all additions of project euler condition checks in a single PR? |
@appgurueu I can make the changes as you mentioned. But the readme file says,
So changing all the Project Euler changes will result in the change into multiple files. That's why I haven't done that yet! Do we need to change that rule? |
The "rule" is a bit overly strict, yes. I'd see it more as a guideline, though. I think that for PRs that don't add or modify algorithms or their tests (e.g. chores like this one), it is absolutely fine to do them "in bulk". These PRs are also an exception in that since these are all "Project Euler condition checks", it is more of a chore than adding tests normally is, which usually is a different matter as reviewing the tests requires knowledge of the problem the algorithm is supposed to solve. |
I am totally happy to do so @appgurueu, but slightly disagree as the guideline doesn't match with this decision. However, we can do them in a single PR. For now, let's merge these PR (which are already done) and next, I'll try to put all of the Project Euler changes in the single PR. |
…rnath98/Javascript into test-cases-project-euler-9
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.