🌐 Added and corrected strings in the Norwegian i18n locale files. #21904
Conversation
no issue - added missing strings - corrected one string
… IANA. `no` is a macrolanguage that encompasses the following more specific primary language subtags: * `nb` - norwegian bokmål * `nn` - norwegian nynorsk If it doesn't break legacy usage for an application, you should use one of these more specific language subtags instead. The node.js versions Ghost supports align with using the more specific language subtags. As the text in the no locale folder is in Norwegian bokmål, the folder has been renamed to nb. Ref.: * [r12a - apps - BCP47 language subtag lookup](https://r12a.github.io/app-subtags/) * [IANA - Language Subtag Registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry * [W3C - Language tags in HTML and XML](htps://www.w3.org/International/questions/qa-choosing-language-tags)
There was a problem hiding this comment.
Really important context missing from your PR main message and buried in a comment (95e98fc) : You're changing the locale code from no to nb.
The proposed change is going to break translations for all sites that currently use the 'no' locale.
Additionally, if the change is going to be made, the supported_locales variable of i18n.js must be updated also. (Otherwise it won't work for EITHER locale code.)
It sounds like a switch to 'nb' is the right thing to do, but it needs to be done with more care than the current PR. sym-linking might be appropriate, but I'm not sure if the current build step for translation files can actually handle it.
|
@cathysarisky nice catch! I haven't tried this so we'd need to test, but it looks like i18next supports a fallbackLng parameter which we might be able to use here. If I'm reading the docs right, basically we'd set |
|
Hey @xqus , would you like to review these proposed translations? |
| "Neurosurgeon": "Neurokirurg", | ||
| "Once deleted, this comment can’t be recovered.": "", | ||
| "Neurosurgeon": "Nevrokirurg", | ||
| "Once deleted, this comment can’t be recovered.": "Når slettet, kan ikke kommentaren gjenopprettes.", |
There was a problem hiding this comment.
Maybe change to: Når denne kommentaren er slettet kan den ikke gjennopprettes..
This is a more natural way to say it in Norwegian.
|
There are two things going on here. One: Fixes to language. Those will be mergeable fairly quickly. Two: The change to locale. That's going to require someone to work through making fallback strings work so that we don't break anything for existing users. (Alternative: write a database migration that switches anyone set to 'no' to 'nb' ?) I'm not going to get a chance to do that for a while -- overbooked with paying work. @knutid, if adding that is within your skill set, please have at it! Otherwise, you're waiting for someone to pick it up and figure it out. So... it might be best to split the locale change out from the translation adjustments. That'll get the translation adjustments in sooner, and decouples the issue of what the locale name is from the changes wanted in it. |
|
My javascript-foo is totally missing. So, I'll look into splitting, @cathysarisky. |
no issue