Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Norwegian a18n Translation #22194

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Update Norwegian a18n Translation #22194

wants to merge 7 commits into from
+27 −24

Conversation

Stealcase
Copy link

This PR addresses 3 issues:

  • Some of the translations in the Norwegian Bokmål had clumsy and non-colloquial wording: they read like english sentences run through google translate.
  • Some new English JSON keys have been introduced which were missing a Norwegian translation. I added the missing translations.
  • no is not the correct ISO language code for Norwegian Bokmål. At best, no is an alias for nb (Norsk Bokmål). I introduced the nb-NO folder for Norsk Bokmål as it is more correct, and matches closer with what i18n calls the language.

Why does this matter?

This PR is marked as a draft since I need to test against regressions, and make sure the fallbackLng change actually works as intended.

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • [ x] There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cathysarisky
Copy link
Contributor

I'm going to try the fallback setting locally and confirm it works. I think that an automated test for the behavior would also be good. See https://github.com/TryGhost/Ghost/blob/main/ghost/i18n/test/i18n.test.js for the right place to put the test and some examples. It'd be good to see that 'no' results in the nb text in a test.

@cathysarisky
Copy link
Contributor

I've manually confirmed that the fallback works in portal, search, comments, newsletter, and magic link! Huzzah!
(I still think a test is a good idea.)

cathysarisky
cathysarisky approved these changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment. Looks good to me.

@cathysarisky
Copy link
Contributor

I just realized this partially duplicates a December PR - #21904
Since this PR has a working fallback, I'd be inclined to move it forward, but I'd love to have the input of the other Norwegians on the wording. @xqus @knutid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathysarisky cathysarisky cathysarisky approved these changes

Assignees
No one assigned
Labels
affects:i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stealcase @cathysarisky @kevinansfield