Handle already aborted controllers before re-aborting #250
Conversation
Previously, the code attempted to abort controllers without checking their state, potentially causing issues. This change ensures that controllers are only aborted if they are not already in an aborted state, improving robustness and preventing unnecessary operations.
|
I've run into a similar issue around this. This fix would be helpful to get in. |
|
@ActuallyConnor @Shinypaper what was the impact of calling abort twice? I'd expect the second one to be a no-op. |
@kwasniew Great question. For our case we noticed it was causing page hang ups occasionally. Our session replay functionality caught the issue and flagged it for me. Just wanted to help out and address our issue simultaneously. 😄 |
|
@kwasniew just curious what the release process would be for this PR once merged? Would it be batched with some other changes or go out as a patch? |
|
@ActuallyConnor we can merge it right now and release a patch version |
|
@ActuallyConnor your change is out as 3.7.6. Thanks for your contribution! |
Previously, the code attempted to abort controllers without checking their state, potentially causing issues. This change ensures that controllers are only aborted if they are not already in an aborted state, improving robustness and preventing unnecessary operations.
About the changes
Closes #
Important files
Discussion points