Handle already aborted controllers before re-aborting #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the code attempted to abort controllers without checking their state, potentially causing issues. This change ensures that controllers are only aborted if they are not already in an aborted state, improving robustness and preventing unnecessary operations.
|
I've run into a similar issue around this. This fix would be helpful to get in. |
Tymek
approved these changes
Apr 23, 2025
kwasniew
approved these changes
Apr 23, 2025
|
@ActuallyConnor @Shinypaper what was the impact of calling abort twice? I'd expect the second one to be a no-op. |
@kwasniew Great question. For our case we noticed it was causing page hang ups occasionally. Our session replay functionality caught the issue and flagged it for me. Just wanted to help out and address our issue simultaneously. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code attempted to abort controllers without checking their state, potentially causing issues. This change ensures that controllers are only aborted if they are not already in an aborted state, improving robustness and preventing unnecessary operations.
About the changes
Closes #
Important files
Discussion points