Solves #109, extended User-Agent data #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Pete (@nerdguru), thank you for submitting this. I would like to play with this header (see what the finished results look like) and pull the header generation code out of the |
|
I will push this to a feature branch and work on the code a bit. -Thank you! |
|
Sounds good to me, thanks! |
Closed
sQu4rks
reviewed
Jul 9, 2020
| @@ -48,6 +52,7 @@ | |||
| check_response_code, check_type, extract_and_parse_json, validate_base_url, | |||
| ) | |||
|
|
|||
| from webexteamssdk._version import get_versions | |||
|
|
|||
| # Helper Functions | |||
There was a problem hiding this comment.
flake8 on the CI is failing because there is a blank line missing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new code I added to extend the User-Agent data passes the linter, but an existing line now gets barked at for reasons that aren't clear, so I thought I'd submit to see if someone more expert could figure that out or if it'll go away.
The only part I was unsure of was the ability to set the two optional fields using environment variables. I went the quick route and pull the variables inside restsession.py but if you want me to follow the model of environments.py I can do that and resubmit. Since the paramaters are optional and the API key set by environments.py is required, I wasn't sure which way would be preferable.