Skip to content

Disable universal2 macOS builds #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Disable universal2 macOS builds #175

merged 3 commits into from
Jul 11, 2022

Conversation

vsafonkin
Copy link

Since the universal2 build of python for macOS brought some breaking changes for customers, we need to disable it temporary.

See PR discussion: #114

@vsafonkin vsafonkin requested a review from a team June 30, 2022 13:11
@alex
Copy link

alex commented Jul 8, 2022

What needs to happen to get this merged?

@marko-zivic-93
Copy link
Contributor

Hello @alex
We are sorry for the delay. We are working on resolving failing tests. As soon as we are done with that, we will merge this PR. Thank you for understanding :)

@alex
Copy link

alex commented Jul 8, 2022

Got it, thanks!

@vsafonkin vsafonkin merged commit 714163c into actions:main Jul 11, 2022
@vsafonkin vsafonkin deleted the v-vsafonkin/disable-universal2 branch July 11, 2022 14:09
@alex
Copy link

alex commented Jul 15, 2022

Can Python 3.10 be rebuilt with this? I'm not sure how exactly this works, but the latest tag for Python 3.10 is still built as universal2.

@vsafonkin
Copy link
Author

Hi @alex, python 3.10.4 and 3.10.5 were rebuilt: #177

@alex
Copy link

alex commented Jul 19, 2022 via email

@alex
Copy link

alex commented Jul 19, 2022

Hmm, no on further review it looks like those builds do not contain this fix.

@alex
Copy link

alex commented Jul 19, 2022

My apologies, those builds do appear to contain the fix, but jobs aren't picking them up: https://github.com/pyca/cryptography/runs/7407788257?check_suite_focus=true

@vsafonkin
Copy link
Author

My apologies, those builds do appear to contain the fix, but jobs aren't picking them up: https://github.com/pyca/cryptography/runs/7407788257?check_suite_focus=true

@alex, it's possible because macOS runner has pre-installed python binaries for 3.10.5:
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-12-Readme.md#python

The macOS runner will be updated at this week or next week, I believe. Or you can remove preinstalled python before setup-python step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants