Skip to content

Update examples to use ulab.numpy #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2021
Merged

Update examples to use ulab.numpy #15

merged 1 commit into from
Dec 30, 2021

Conversation

dhalbert
Copy link
Contributor

Fixes #14.

@dhalbert dhalbert requested a review from a team December 30, 2021 15:40
@rsbohn
Copy link

rsbohn commented Dec 30, 2021

Should the example support CP6?

@rsbohn
Copy link

rsbohn commented Dec 30, 2021

Looks good for CP 7.x.

@dhalbert
Copy link
Contributor Author

Should the example support CP6?

No, we are no longer making 6.x bundles, since 7.x has been out for a while and continuing with some compatibility code is difficult. There is a list of the last x.x bundles here: https://learn.adafruit.com/welcome-to-circuitpython/frequently-asked-questions#faq-3105289

FoamyGuy
FoamyGuy approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @dhalbert

tested successfully on CLUE 7.2.0 alpha 1

@FoamyGuy FoamyGuy merged commit 3f95470 into adafruit:main Dec 30, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 31, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e796bc0)
27835f3 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.14 from 3.5.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#148 from tekktrik/doc/status-led-connect

Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#18 from CedarGroveStudios/main
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#15 from dhalbert/ulab-numpy
  > update rtd py version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

example needs updating for CP 7.x
3 participants
@dhalbert @rsbohn @FoamyGuy