Skip to content

Remove max_size parameter #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2021
Merged

Conversation

lesamouraipourpre
Copy link
Contributor

Remove the max_size parameter. It is no longer used by displayio.Group
Ref: adafruit/circuitpython#4959

Update the requirements.txt and setup.py so that pip can install it.

Modify the docs, so that the API docs build. Note: the docs have not been checked for validity.

This has not been tested - it needs gamepadshift and I don't have a suitable device:
https://circuitpython.readthedocs.io/en/latest/shared-bindings/support_matrix.html?filter=gamepadshift

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Jul 2, 2021

There are a few more uses of max_size in the examples:

examples/cursorcontrol_buttons_text.py:17:splash = displayio.Group(max_size=22)
examples/cursorcontrol_custom_cursor.py:14:splash = displayio.Group(max_size=5)
examples/cursorcontrol_simpletest.py:14:splash = displayio.Group(max_size=5)

The rest of these changes look good to me, thanks for docs fixes!

@lesamouraipourpre
Copy link
Contributor Author

Oops. I got distracted by the docs. That should be it now.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Tested successfully with a PyGamer on CircuitPython 6.3.0.

@FoamyGuy FoamyGuy merged commit 12274ab into adafruit:main Jul 3, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 4, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.3.0 from 2.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#24 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#2 from lesamouraipourpre/max-size

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.8.0 from 1.7.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#42 from lesamouraipourpre/max-size
@lesamouraipourpre lesamouraipourpre deleted the max-size branch July 6, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants