Skip to content

Remove displayio.Group max_size parameter from libraries #4959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
40 of 41 tasks
lesamouraipourpre opened this issue Jul 1, 2021 · 3 comments · Fixed by #5040
Closed
40 of 41 tasks

Remove displayio.Group max_size parameter from libraries #4959

lesamouraipourpre opened this issue Jul 1, 2021 · 3 comments · Fixed by #5040
Assignees
@lesamouraipourpre
Labels
displayio enhancement library
Milestone
7.0.0

Comments

@lesamouraipourpre
Copy link

lesamouraipourpre commented Jul 1, 2021 •
edited
Loading

Now that max_size has been disabled in shared-bindings/displayio/Group.c ready for removal in CircuitPython 7, it needs to be removed from all the libraries that make use of it before this can happen.

circuitpython/shared-bindings/displayio/Group.c

Line 45 in 37c5211

//| :param int max_size: Ignored. Will be removed in 7.x.

I propose to work through the libraries and make the necessary PRs. This Issue is intended as a central tracking point which will eventually allow the removal of the parameter from shared-bindings, hopefully before the release-candidate of CP7.

Below is the output of grep -r max_size * | grep -v adafruit_fram | sort against Adafruit_CircuitPython_Bundle/libraries at Fri 16 Jul 17:03:22 BST 2021

drivers/displayio_sh1106/examples/displayio_sh1106_simpletest.py:splash = displayio.Group(max_size=10)
drivers/displayio_sh1106/README.rst:    splash = displayio.Group(max_size=10)
drivers/monsterm4sk/examples/monsterm4sk_pumpkin_shifting_eyes.py:left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_pumpkin_shifting_eyes.py:right_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_rainbow_stars.py:left_group = displayio.Group(max_size=4, scale=3)
drivers/monsterm4sk/examples/monsterm4sk_rainbow_stars.py:right_group = displayio.Group(max_size=4, scale=3)
drivers/monsterm4sk/examples/monsterm4sk_simpletest.py:left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_simpletest.py:right_group = displayio.Group(max_size=4)
drivers/monsterm4sk/README.rst:    left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/README.rst:    right_group = displayio.Group(max_size=4)
drivers/ssd1325/examples/ssd1325_simpletest.py:    max_size=10,
drivers/ssd1325/examples/ssd1325_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:text_group_left = displayio.Group(max_size=10, scale=1, x=0, y=6)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:text_group_right = displayio.Group(max_size=10, scale=1, x=80, y=6)
drivers/st7735r/examples/st7735r_128x160_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=64)
drivers/st7735r/examples/st7735r_minitft_featherwing_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_minitft_featherwing_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=40)
drivers/st7735r/examples/st7735r_minitft_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_minitft_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=40)
drivers/st7735r/examples/st7735r_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/README.rst:    splash = displayio.Group(max_size=10)
@FoamyGuy
Copy link
Collaborator

FoamyGuy commented Jul 1, 2021

Thanks for putting this together. We'll need to run a similar pass through the learn guide repo to change instances of this as well.

@lesamouraipourpre lesamouraipourpre changed the title Remove display.Group max_size parameter from libraries Remove displayio.Group max_size parameter from libraries Jul 2, 2021
@microdev1 microdev1 added this to the 7.0.0 milestone Jul 2, 2021
This was referenced Jul 2, 2021
Merged
Merged
Merged
Merged
Merged
Merged
@jposada202020
Copy link

@lesamouraipourpre I give all the thanks here for all these PRs. This is hard work!!!

This was referenced Jul 2, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 4, 2021
Merged
Merged
Merged
Merged
Merged
@jposada202020
Copy link

Arrowline Done --> https://github.com/jposada202020/CircuitPython_ArrowLine/releases/tag/0.8.1
Candlesticks Done --> https://github.com/jposada202020/CircuitPython_Candlesticks/releases/tag/0.6.1
Styles Done --> https://github.com/jposada202020/CircuitPython_styles/releases/tag/0.5.1

This was referenced Jul 5, 2021
Merged
Closed
Merged
This was referenced Jul 5, 2021
Merged
Merged
Closed
@lesamouraipourpre lesamouraipourpre mentioned this issue Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lesamouraipourpre lesamouraipourpre

Labels
displayio enhancement library
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Remove the max_size parameter from displayio.Group
4 participants
@FoamyGuy @jposada202020 @microdev1 @lesamouraipourpre