Add altitude property #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tannewt merged 2 commits into adafruit:master from caternuson:iss8

Aug 28, 2020

Contributor

caternuson commented Aug 27, 2020

For #8. Adds an altitude property.

Adafruit CircuitPython 5.3.1 on 2020-07-13; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import board
>>> import adafruit_dps310
>>> dps310 = adafruit_dps310.DPS310(board.I2C())
>>> dps310.altitude
65.4015
>>> dps310.sea_level_pressure
1013.25
>>> dps310.sea_level_pressure = 1012.42
>>> dps310.altitude
58.4471
>>>

caternuson added 2 commits

August 27, 2020 11:02


          add altitude property

aeefb83


          ahh...pylint, my old friend

a2ec35b

caternuson requested a review from a team

August 27, 2020 18:17

tannewt approved these changes

View reviewed changes

Member

tannewt left a comment

Looks good! Thank you!

tannewt merged commit 8e8a175 into adafruit:master

Contributor Author

caternuson commented Aug 31, 2020

@tannewt Thanks. Did you see discussion in issue thread?
#8
Maybe this should have been closed? Not merged? I'm fine with whatever.

Member

tannewt commented Aug 31, 2020

Nope, just saw the PR. Feel free to revert this.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@b17b8fd)

9a5a828

Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.1 from 3.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#48 from adafruit/lint
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#47 from michaellass/start_paused

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.0 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#9 from caternuson/iss8

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.0 from 3.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#105 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#104 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.6.5 from 2.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#31 from esmil/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.6.3 from 1.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#52 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.1.0 from 4.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#44 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.3.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#13 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#12 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#48 from kattni/update-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.6.0 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#30 from tannewt/add_tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet