Skip to content

remove bad-whitespace pylint directive #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2020

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Aug 23, 2020

This directive has been removed from pylint 2.6.0.

@dhalbert dhalbert requested a review from a team August 23, 2020 17:23
@jepler
Copy link
Contributor Author

jepler commented Aug 23, 2020

Fails due to unrelated pylint wrong-import-order errors I do not reproduce locally with pylint 2.6.0, such as

adafruit_esp32spi/adafruit_esp32spi_wifimanager.py:20:0: C0411: third party import "import adafruit_requests as requests" should be placed before "from adafruit_esp32spi import adafruit_esp32spi" (wrong-import-order)

@kattni
Copy link
Contributor

kattni commented Aug 24, 2020

@jepler I would suggest updating the import order, but be prepared for it to cascade fail on the list of imports one at a time. Your local environment probably isn't exactly like the remote environment, and that's why it's not failing locally for you. I've had it happen.

@makermelissa makermelissa merged commit 6fc889d into adafruit:master Aug 27, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 1, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.1 from 3.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#48 from adafruit/lint
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#47 from michaellass/start_paused

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.0 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#9 from caternuson/iss8

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.0 from 3.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#105 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#104 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.6.5 from 2.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#31 from esmil/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.6.3 from 1.6.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#52 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.1.0 from 4.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#44 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.3.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#13 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#12 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#48 from kattni/update-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.6.0 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#30 from tannewt/add_tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants