Skip to content

Remove max_size parameter #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2021
Merged

Remove max_size parameter #2

merged 1 commit into from
Jul 3, 2021

Conversation

lesamouraipourpre
Copy link
Contributor

Remove the max_size parameter. It is no longer used by displayio.Group
Ref: adafruit/circuitpython#4959

I don't have a FunHouse to test this with.

@lesamouraipourpre lesamouraipourpre mentioned this pull request Jul 2, 2021
Closed
41 tasks
FoamyGuy
FoamyGuy approved these changes Jul 3, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I tested the advancedtest example succefully on a FunHouse with CircuitPython 7.0.0.alpha-3

@FoamyGuy FoamyGuy merged commit 7c475ac into adafruit:main Jul 3, 2021
@lesamouraipourpre lesamouraipourpre deleted the max-size branch July 6, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesamouraipourpre @FoamyGuy