Remove max_size parameter #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
There was a problem hiding this comment.
@lesamouraipourpre
Not sure why the adafruit_button.py is included in the changes, could be that you are working in the bundle?
besides this, LGTM. was tested using the display_button_customfont.py using as a font terminalio.FONT. tested on:
Adafruit CircuitPython 6.3.0 on 2021-06-01; Adafruit PyPortal Titano with samd51j20|
It removed the execute bits from it - 100755 → 100644. |
jposada202020
approved these changes
Jul 2, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 7, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.3.0 from 2.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#46 from jposada202020/adding_note > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#45 from lesamouraipourpre/max-size > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.6.0 from 1.5.5: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#32 from lesamouraipourpre/requirements > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#31 from lesamouraipourpre/max-size > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 2.3.0 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#32 from lesamouraipourpre/max-size > Moved default branch to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
max_sizeparameter. It is no longer used bydisplayio.GroupRef: adafruit/circuitpython#4959
Test on a Pynt: