Remove max_size parameter #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
FoamyGuy
reviewed
Jul 1, 2021
| @@ -81,18 +81,15 @@ def __init__(self, font, **kwargs) -> None: | |||
| text = kwargs.get("text", "") | |||
|
|
|||
| if not max_glyphs and not text: | |||
| raise RuntimeError("Please provide a max size, or initial text") | |||
| raise RuntimeError("Please provide a max_glyphs, or initial text") | |||
There was a problem hiding this comment.
I think we may be able to get rid of max_glyphs. if I understand correctly, the reason for that restriction and parameter was the underlying Group's max_size.
There was a problem hiding this comment.
It's assigned to width further down so I didn't want to mess with it for now.
There was a problem hiding this comment.
Interesting. I'll test out this change as-is, we can merge it now if good and then remove it in a followup.
it seems odd that it would use that for width without multiplying by the width of the glyph in pixels. I can poke into it a bit and try to figure out if it's needed or how to replace it with something different.
FoamyGuy
approved these changes
Jul 1, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 2, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_OV2640 to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_OV2640#3 from adafruit/ulab-example Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.12.0 from 2.11.6: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#66 from mcauser/patch Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.3.8 from 3.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#37 from silviaCC/simpletest_and_color_rgb_update > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.6 from 2.18.5: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#153 from lesamouraipourpre/max-size Updating https://github.com/adafruit/Adafruit_CircuitPython_Simple_Text_Display to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Simple_Text_Display#2 from kattni/pypi Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Simple_Text_Display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131
Remove the
max_sizeparameter fromLabelandBitmapLabelnow that it has been disabled inshared-bindings.This has been tested with: