Skip to content

Many updates, new functions, flow control, simplified examples #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 25, 2018

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Dec 24, 2018

big scrubbin'!

jerry - i think you tried this out, so putting you on the review

@ladyada ladyada requested a review from jerryneedell December 24, 2018 23:27
import busio
from digitalio import DigitalInOut
import audioio
from Adafruit_CircuitPython_ESP_ATcontrol import adafruit_espatcontrol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be import adafruit_espatcontrol for released version

@jerryneedell
Copy link
Contributor

minor comments for some of the example -- I have run this on a metrom4 express with both an ESP32 and ESP8266 -- both work well. Took awhile to get the right flow control pin on the ESP8266! (GPIO13)
I have also run it on a particle argon -- a few minor changes are needed for the setup of the onboard ESP32 and for some known issues with nrf52840 UART implementation but all the demos work - the highest baudrate I was able to use was 460800.

Copy link
Contributor

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in comments -- this is working on a metrom4 with ESP32 or ESP8266 and with minor changes works on a particle argon. It will be good to have this PR in place - it is a big improvement.

@ladyada ladyada merged commit 6776e9d into adafruit:master Dec 25, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 27, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.2.0 from 0.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#11 from jerryneedell/jerryn_addpost
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#10 from ladyada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SharpMemoryDisplay to 1.0.0 from 599e0c5:
  < Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#5 from deshipu/master
  < Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#4 from deshipu/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_US100 to 1.0.0 from 515342e:
  < Merge pull request adafruit/Adafruit_CircuitPython_US100#4 from sommersoft/readme_fix_travis

Updating https://github.com/adafruit/Adafruit_CircuitPython_ServoKit to 1.0.1 from 172e66f:
  < Merge pull request adafruit/Adafruit_CircuitPython_ServoKit#4 from kattni/example-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_PCD8544, Adafruit_CircuitPython_SharpMemoryDisplay, Adafruit_CircuitPython_US100, Adafruit_CircuitPython_framebuf, Adafruit_CircuitPython_ServoKit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants