-
Notifications
You must be signed in to change notification settings - Fork 16
Many updates, new functions, flow control, simplified examples #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e flow control, tested up to 460k
…mo with selectable data sources
examples/espatcontrol_countviewer.py
Outdated
import busio | ||
from digitalio import DigitalInOut | ||
import audioio | ||
from Adafruit_CircuitPython_ESP_ATcontrol import adafruit_espatcontrol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should just be import adafruit_espatcontrol for released version
minor comments for some of the example -- I have run this on a metrom4 express with both an ESP32 and ESP8266 -- both work well. Took awhile to get the right flow control pin on the ESP8266! (GPIO13) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in comments -- this is working on a metrom4 with ESP32 or ESP8266 and with minor changes works on a particle argon. It will be good to have this PR in place - it is a big improvement.
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.2.0 from 0.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#11 from jerryneedell/jerryn_addpost > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#10 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SharpMemoryDisplay to 1.0.0 from 599e0c5: < Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#5 from deshipu/master < Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#4 from deshipu/master Updating https://github.com/adafruit/Adafruit_CircuitPython_US100 to 1.0.0 from 515342e: < Merge pull request adafruit/Adafruit_CircuitPython_US100#4 from sommersoft/readme_fix_travis Updating https://github.com/adafruit/Adafruit_CircuitPython_ServoKit to 1.0.1 from 172e66f: < Merge pull request adafruit/Adafruit_CircuitPython_ServoKit#4 from kattni/example-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_PCD8544, Adafruit_CircuitPython_SharpMemoryDisplay, Adafruit_CircuitPython_US100, Adafruit_CircuitPython_framebuf, Adafruit_CircuitPython_ServoKit
big scrubbin'!
jerry - i think you tried this out, so putting you on the review