Skip to content

renamed files #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

renamed files #32

wants to merge 6 commits into from

Conversation

williamlai2
Copy link
Contributor

from here: #31

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up!

The only example that I wanted renamed as motor_servo_sweep.py. The others should be left as they were. Please return the four you renamed to their original names, and rename motor_servo_sweep.py to motor_servo_sweep_simpletest.py.

As well, you'll need to update the examples.rst file in the docs/ folder (/docs/examples.rst) to reflect the name change:

Simple tests
-------------

Ensure your device works with this simple test.

.. literalinclude:: ../examples/motor_servo_sweep.py
    :caption: examplesmotor_servo_sweep.py
    :linenos:

Will need to be:

Simple tests
-------------

Ensure your device works with this simple test.

.. literalinclude:: ../examples/motor_servo_sweep_simpletest.py
    :caption: examples/motor_servo_sweep_simpletest.py
    :linenos:

@williamlai2
Copy link
Contributor Author

I have updated those files. I had to re-upload the 'examples' folder as it disappeared from the branch, but it is the same as before, just renamed.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. The build is still failing due to all of the line endings in the examples you re-uploaded having CRLF line-endings vs the original LF line-endings.

Unfortunately I think the best option may be to close this PR, and create a new one with only the necessary changes included. I apologise for the inconvenience, but I think that route will be the simplest vs trying to fix all the example code manually.

Please let me know if you have any questions or need assistance with that.

@williamlai2
Copy link
Contributor Author

Sorry about that. I will close it and try again.

@williamlai2 williamlai2 closed this Oct 2, 2019
@kattni
Copy link
Contributor

kattni commented Oct 2, 2019

Closing in favor of #33

@williamlai2
Copy link
Contributor Author

Thanks for the advice. I learnt quite a bit in doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants