Skip to content

use onewireio instead of busio #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

use onewireio instead of busio #26

merged 1 commit into from
Jun 10, 2022

Conversation

dhalbert
Copy link
Contributor

We are moving OneWire to its own module.

In CircuitPython 6.x.x, OneWire is available as busio.OneWire.
In CircuitPython 7.x.x, OneWire is available as busio.OneWire and as onewireio.OneWire.
In CircuitPython 8.x.x, OneWire will be available only as onewireio.OneWire.

Have this library catch up to onewireio.OneWire. This will be a major version change.

@dhalbert dhalbert requested a review from a team June 10, 2022 16:48
@dhalbert
Copy link
Contributor Author

This is necessary to allow the library to work on CircuitPython 8.0.0-alpha.1.

tekktrik
tekktrik approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @dhalbert, does it make sense to sit on this, or to merge and release a pre-release version, or to merge and do an actual release?

@dhalbert
Copy link
Contributor Author

Looks good to me. @dhalbert, does it make sense to sit on this, or to merge and release a pre-release version, or to merge and do an actual release?

This is upward compatible with 7.x, so I will release it

@dhalbert dhalbert merged commit aea5dff into adafruit:main Jun 10, 2022
@dhalbert dhalbert deleted the use-onewireio branch June 10, 2022 18:15
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 11, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@4d873a0)
8ff94ab 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.11 from 1.10.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#102 from caternuson/iss101_bpp

Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 2.0.0 from 1.2.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#26 from dhalbert/use-onewireio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tekktrik