Skip to content

Lint all the libraries! #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tannewt opened this issue Dec 7, 2017 · 11 comments
Closed

Lint all the libraries! #475

tannewt opened this issue Dec 7, 2017 · 11 comments
Labels
library
Milestone
3.0 Alpha

Comments

@tannewt
Copy link
Member

tannewt commented Dec 7, 2017 •
edited by mrmcwethy
Loading

I'm going through and updating the libraries to our new build process and to turn on lint. Here is the process:

  1. Copy .pylintrc from the cookiecutter repo into the new repo.
  2. Add this to .gitignore
.env
build*
bundles
  1. Copy .travis.yml from cookiecutter into the repo overwriting the old version.
  2. Update lines 1 and 3 of the script section of .travis.yml to reflect the driver name.
  3. Add this to all modules in the driver with the correct repo url below the module comment:
__version__ = "0.0.0-auto.0"
__repo__ = "<repo url"
  1. Run pylint on all modules and fix all errors.
  2. Run pylint --disable=missing-docstring,invalid-name examples/*.py to pylint all examples and fix all errors.

If you are doing the PR then please check the box below before you start! That way no one else will do it at the same time.

Remaining

Pending PRs

These PRs may need testing before they can be merged.

Complete PRs

These PRs complete with testing and releases!
This was referenced Dec 7, 2017
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@tannewt
Copy link
Member Author

tannewt commented Dec 7, 2017

Background on the lint configs is available here: adafruit/cookiecutter-adafruit-circuitpython#6

tannewt added a commit to tannewt/Adafruit_CircuitPython_VL53L0X that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
6343dc1 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
tannewt added a commit to chickadee-tech/Adafruit_CircuitPython_NeoPixel that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
92a73e5 
This introduces a minor change to the constructor API because the kwargs now must be keywords and not positional.

I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_LIS3DH that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
961e581 
This also standardizes the README and CODE_OF_CONDUCT.

I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_CharLCD that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
3a73e11 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
tannewt added a commit to tannewt/Adafruit_CircuitPython_Register that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
d7893ca 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
tannewt added a commit to tannewt/Adafruit_CircuitPython_Register that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
3aacc2f 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_AMG88xx that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
761fcd5 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
@mrmcwethy
Copy link

I will start with MAX7219

tannewt added a commit to tannewt/Adafruit_CircuitPython_ADS1x15 that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
a48c2bd 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_PCF8523 that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
4628c9c 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_MPR121 that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
f03cfd3 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
tannewt added a commit to chickadee-tech/Adafruit_CircuitPython_CCS811 that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
d9a8160 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 8, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_BusDevice that referenced this issue Dec 8, 2017
@tannewt
Update to new build process and turn on lint.
c459a7d 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@mrmcwethy
Copy link

I may have lost changes by ladyada and katni. changed your comment for this issue to added a PRs ready for review category. Also tried to reinstate PRs Complete category.

@mrmcwethy
Copy link

I as working on Char_LCD and RGB_Display

tannewt added a commit to tannewt/Adafruit_CircuitPython_IRRemote that referenced this issue Dec 13, 2017
@tannewt
Update to new build process and turn on lint.
c9ca44c 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
tannewt added a commit to tannewt/Adafruit_CircuitPython_IRRemote that referenced this issue Dec 13, 2017
@tannewt
Update to new build process and turn on lint.
229539c 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 13, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_seesaw that referenced this issue Dec 13, 2017
@tannewt
Update to new build process and turn on lint.
07e3eda 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 13, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_Thermistor that referenced this issue Dec 13, 2017
@tannewt
Update to new build process and turn on lint.
85f92cb 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@tannewt tannewt mentioned this issue Dec 13, 2017
Merged
This was referenced Dec 13, 2017
Merged
Merged
Merged
@mrmcwethy
Copy link

I am starting on pylint of SD

@mrmcwethy mrmcwethy mentioned this issue Dec 13, 2017
Merged
@mrmcwethy
Copy link

I am picking up SimpleIO.

This was referenced Dec 13, 2017
Merged
Merged
@mrmcwethy
Copy link

i also did wavefrom

@tannewt tannewt mentioned this issue Dec 14, 2017
Closed
@mrmcwethy
Copy link

I am starting on HID

@mrmcwethy mrmcwethy mentioned this issue Dec 14, 2017
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_AMG88xx that referenced this issue Dec 18, 2017
@tannewt
Update to new build process and turn on lint.
234e2cb 
I haven't tested these changes on device yet. Please only merge you test it or I follow up later to say its tested.

For adafruit/circuitpython#475
@mrmcwethy mrmcwethy mentioned this issue Jan 3, 2018
Merged
@tannewt tannewt mentioned this issue Jan 6, 2018
Merged
@tannewt
Copy link
Member Author

tannewt commented Jan 9, 2018

I'm doing IS31FL3731. I believe its the last one.

@tannewt tannewt added this to the 3.0 Beta milestone Jan 16, 2018
@tannewt tannewt mentioned this issue Jan 16, 2018
Closed
@mrmcwethy
Copy link

There was a lot of work involved with incorporating pylint into the library build process and it is complete. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
library
Projects
None yet
Milestone
3.0 Alpha
Development

No branches or pull requests
2 participants
@tannewt @mrmcwethy