Add default lint checks. #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
reviewed
Dec 6, 2017
There was a problem hiding this comment.
Looks good! Since it works I don't have a lot to say about the .travis.yml stuff.
In .pylintrc, could you include the original settings in a comment line and then duplicate the line below with our changes? That way we can see how we deviate from the norm. E.g.,
#good-names=i,j,k,ex,Run,_
good-names=r,g,b,i,j,k,n,ex,Run,_
|
@dhalbert Done. |
dhalbert
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two example commits that implement changes based on lint are adafruit/Adafruit_CircuitPython_BME280#3 and adafruit/Adafruit_CircuitPython_DotStar#8.
The lint file is pylint's defaults with a few changes:
import-errorturned off because CircuitPython built-ins trigger itr,g,bandnare whitelisted single character variable names.