Skip to content

Remove the max_size parameter from displayio.Group #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Remove the max_size parameter from displayio.Group #5040

merged 1 commit into from
Jul 22, 2021

Conversation

lesamouraipourpre
Copy link

Remove max_size parameter from displayio.Group
Closes #4959

This is potentially a breaking change as the constructor signature is changing.

Status of dependents:

Frozen modules

> grep -r max_size frozen | wc
      0       0       0

All frozen modules that use max_size have been updated

Adafruit_CircuitPython_Bundle libraries - after the next release

>> Adafruit_CircuitPython_Bundle  main
> .update-submodules.sh
> grep -r max_size * | grep -v adafruit_fram
libraries/drivers/displayio_sh1106/examples/displayio_sh1106_simpletest.py:splash = displayio.Group(max_size=10)
libraries/drivers/displayio_sh1106/README.rst:    splash = displayio.Group(max_size=10)

All code/examples/docs have been updated, merged and released except

CircuitPython_Org_Bundle
All code/example/docs have been updated, merged and released.

CircuitPython_Community_Bundle libraries

>> CircuitPython_Community_Bundle  master
> .update-submodules.sh
> grep -r max_size *
libraries/drivers/gc9a01/examples/gc9a01_simpletest.py:splash = displayio.Group(max_size=10)
libraries/drivers/gc9a01/README.rst:    splash = displayio.Group(max_size=10)
libraries/drivers/ili9163/examples/ili9163_simpletest.py:splash = displayio.Group(max_size=10)
libraries/drivers/ili9163/README.rst:    splash = displayio.Group(max_size=10)
libraries/helpers/circuitpython_display_frame/examples/display_frame_pygame_display_simpletest.py:main_group = displayio.Group(max_size=10)

All code/examples/docs have been updated, merged and released except

Learn Guides
adafruit/Adafruit_Learning_System_Guides#1603
Progressing slowly but steadily.

Testing
This has been tested successfully on a PyPortal Pynt with a selection of example code from libraries that previously used max_size.
Adafruit CircuitPython 7.0.0-alpha.5-dirty on 2021-07-22; Adafruit PyPortal with samd51j20

max_size has been ignored for a while with the intention of removing it in 7.0
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks as expected.

I also double-checked that in 6.3, this was already ignored and was not marked MP_ARG_REQUIRED so (as we already satisfied ourselves before) it's possible to write code that's compatible with 6.3 and 7 after this change.

@tannewt tannewt merged commit 779b5c1 into adafruit:main Jul 22, 2021
@tannewt
Copy link
Member

tannewt commented Jul 22, 2021

Thank you @lesamouraipourpre. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove displayio.Group max_size parameter from libraries
3 participants