Remove the max_size parameter from displayio.Group #5040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
max_size
parameter fromdisplayio.Group
Closes #4959
This is potentially a breaking change as the constructor signature is changing.
Status of dependents:
Frozen modules
All frozen modules that use
max_size
have been updatedAdafruit_CircuitPython_Bundle libraries - after the next release
All code/examples/docs have been updated, merged and released except
CircuitPython_Org_Bundle
All code/example/docs have been updated, merged and released.
CircuitPython_Community_Bundle libraries
All code/examples/docs have been updated, merged and released except
Learn Guides
adafruit/Adafruit_Learning_System_Guides#1603
Progressing slowly but steadily.
Testing
This has been tested successfully on a PyPortal Pynt with a selection of example code from libraries that previously used
max_size
.Adafruit CircuitPython 7.0.0-alpha.5-dirty on 2021-07-22; Adafruit PyPortal with samd51j20