Skip to content

Title bar exception indicator: include filename #6702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhalbert opened this issue Aug 5, 2022 · 0 comments · Fixed by #6713
Closed

Title bar exception indicator: include filename #6702

dhalbert opened this issue Aug 5, 2022 · 0 comments · Fixed by #6713
Assignees
@tannewt
Labels
web workflow
Milestone
8.0.0

Comments

@dhalbert
Copy link
Collaborator

dhalbert commented Aug 5, 2022 •
edited
Loading

The @n ExceptionName in the title bar does not include the filename. So for instance:
code.py:

import busio
import x

x.py:

1/0

says @1 DivisionByZeroError without saying which file it's in. If you feel there is room, I think including the filename would be good, since the error may be quite deep. The filename and the line number are more important than a possibly truncated exception name.

From #6698 (review)
@dhalbert dhalbert added this to the 8.0.0 milestone Aug 5, 2022
@tannewt tannewt mentioned this issue Aug 8, 2022
Merged
tannewt added a commit that referenced this issue Aug 9, 2022
@tannewt
Add exception filename to title bar
86f4014 
Add the exception filename after the line number and change the
line number so it is in that file. It used to always be code.py.

Fixes #6702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tannewt tannewt

Labels
web workflow
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Add exception filename to title bar tannewt/circuitpython
2 participants
@tannewt @dhalbert