Skip to content

Look at shared/runtime/stdout_helpers.c after v1.21.0 merge #8510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhalbert opened this issue Oct 24, 2023 · 4 comments · Fixed by #8599
Closed

Look at shared/runtime/stdout_helpers.c after v1.21.0 merge #8510

dhalbert opened this issue Oct 24, 2023 · 4 comments · Fixed by #8599
Labels
enhancement micropython core
Milestone
9.0.0

Comments

@dhalbert
Copy link
Collaborator

See if micropython#7491 for shared/runtime/stdout_helpers.c is worth
incorporating to reduce skew from MicroPython.
@dhalbert dhalbert added this to the 9.0.0 milestone Oct 24, 2023
@jepler
Copy link

jepler commented Nov 13, 2023

It looks like we already use it. It's listed among the source files and I checked an object file from the build for trinket m0:

jepler@bert:~/src/circuitpython/ports/atmel-samd$ arm-none-eabi-nm --plugin /home/jepler/.local/gcc-arm-none-eabi-10-2020-q4-major/lib/gcc/arm-none-eabi/10.2.1/liblto_plugin.so.0.0.0 build-trinket_m0/shared/runtime/stdout_helpers.o
00000000 T mp_hal_stdout_tx_str
         U mp_hal_stdout_tx_strn
00000000 T mp_hal_stdout_tx_strn_cooked

@dhalbert
Copy link
Collaborator Author

I was wondering whether we should pick up the revised version of the code:
image

@jepler
Copy link

jepler commented Nov 13, 2023

[slapping myself on the forehead emoji]

@dhalbert
Copy link
Collaborator Author

It was pretty cryptic :)

@jepler jepler mentioned this issue Nov 13, 2023
Merged
jepler added a commit to jepler/circuitpython that referenced this issue Nov 13, 2023
@jepler
Revert to micropython's version of mp_hal_stdout_tx_strn_cooked
06ee8da 
Closes adafruit#8510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement micropython core
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Revert to micropython's version of mp_hal_stdout_tx_strn_cooked jepler/circuitpython
3 participants
@tannewt @jepler @dhalbert