Skip to content

Audio Effect Multi-Tap Delay #10258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 19, 2025
Merged

Conversation

relic-se
Copy link

@relic-se relic-se commented Apr 16, 2025

Adding a variation of a standard digital delay (no frequency shifting) which allows for multiple "tap" positions to draw from the delay buffer. Rhythmic delay effects can be achieved by using irregular tap positions, ie: dotted quarter notes.

Notes:

  • I've tried to make the taps parameter flexible, but any suggestions are welcome.
  • synthio.BlockInput is not supported at this time. I don't see any immediate benefits from adding in that feature.
  • This feature could be included into the audiodelays.Echo effect instead of its own, but doing so might add too much complexity.
  • Currently, taps=None results in silent output. An alternative would be to have it act as a standard delay in this circumstance.
  • I've re-written the ..._get_buffer(...) slightly to reduce complexity and flash usage. There are some performance drawbacks when not playing a sample through this effect directly, but that scenario is uncommon and the performance hit should be minimal. Another benefit is that trailing delays after a sample has ended should act properly.

@tannewt tannewt requested a review from gamblor21 April 16, 2025 17:47
Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a Pico2 worked great for me. Sounded like the demo you previously showed me.

Code looks good to me. Great work, thanks again!

@gamblor21 gamblor21 merged commit 670d046 into adafruit:main Apr 19, 2025
615 checks passed
@relic-se relic-se deleted the multi-tap-delay branch April 20, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants