Skip to content

Add Chinese (Pinyin) and slim down boards so it fits #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 13, 2019
Merged

Add Chinese (Pinyin) and slim down boards so it fits #1788

merged 15 commits into from
Apr 13, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 12, 2019

No description provided.

@tannewt tannewt mentioned this pull request Apr 12, 2019
Closed
@tannewt tannewt requested a review from dhalbert April 13, 2019 00:17
dhalbert
dhalbert approved these changes Apr 13, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is exciting. Thanks for conditionalizing the inline limits. We might eventually add a "large translation" flag or something similar.

@dhalbert dhalbert merged commit f8473f4 into adafruit:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @dhalbert @hexthat