Skip to content

Improvements to Group #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2019
Merged

Improvements to Group #1888

merged 3 commits into from
May 15, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented May 15, 2019

Makes Group iterable and adds index and remove.

@tannewt tannewt added this to the 4.x milestone May 15, 2019
dhalbert
dhalbert requested changes May 15, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested minimally with a Group containing another Group.

Only issue is a comment. I'm surprised there wasn't a generic iterator already.

@tannewt
Copy link
Member Author

tannewt commented May 15, 2019

I was surprised too. My guess is that it wasn't done due to speed.

We could auto-detect when we could use one too but then we'd need to test for subscr and unary when trying to construct the iterator.

@dhalbert dhalbert merged commit a888fe4 into adafruit:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
circuitpython api displayio enhancement
Projects
None yet
Milestone
4.x - Features
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert