Skip to content

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented May 15, 2019

Makes Group iterable and adds index and remove.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested minimally with a Group containing another Group.

Only issue is a comment. I'm surprised there wasn't a generic iterator already.

@tannewt
Copy link
Member Author

tannewt commented May 15, 2019

I was surprised too. My guess is that it wasn't done due to speed.

We could auto-detect when we could use one too but then we'd need to test for subscr and unary when trying to construct the iterator.

@dhalbert dhalbert merged commit a888fe4 into adafruit:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants