-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix CPB SPI pin definitions #3583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ap_rssi is a bound method, which I'm not keen on, but it works
still need to figure out the bound method business
… esp32s2-morenet
Forgot to make it a property!
… esp32s2-morenet
When allocations were freed in a different order from the reverse of how they were allocated (leaving holes), the heap would get into an inconsistent state, eventually resulting in crashes. free_memory() relies on having allocations in order, but allocate_memory() did not guarantee that: It reused the first allocation with a NULL ptr without ensuring that it was between low_address and high_address. When it belongs to a hole in the allocated memory, such an allocation is not really free for reuse, because free_memory() still needs its length. Instead, explicitly mark allocations available for reuse with a special (invalid) value in the length field. Only allocations that lie between low_address and high_address are marked that way.
This requires recovering the pointer of the allocation, which could be done by adding up neighbor lengths, but the simpler way is to stop NULLing it out in the first place and instead mark an allocation as freed by the client by setting the lowest bit of the length (which is always zero in a valid length).
… esp32s2-morenet
Signed-off-by: Jensen <jensechu@gmail.com>
…rcuitpython into color-converter-transparency
still needs work and cleanup
396979a breaks building on macOS: `nproc` is a Linux thing, use a cross-platform alternative.
This leads to smaller code size at the expense of slower linking. We can turn partitioning back on with GCC10 because it produces smaller code.
Fix missing `nproc` on macOS
Update port status in readme
displayio: Pass transparent_color to ColorConverter
you dont by chance have a tft gizmo or eink gizmo? |
I have a tft-gizmo |
could you test with that too?cause thats what we use for SPI interfacing! |
sure -- will do. |
@ladyada the tft-GiZMO uses A3 for the backlight and uses SDA for MOSI ???
|
ah -- but since it does not call board.SPI() it should be OK |
yeah we 'recycle' the I2C pins - to keep pin compatibilitiy with CPX! |
Tested on CPB with TFT gizmo -- no problems. |
FYI -- this came up in a forum question about using a mini-tft with the CPB. https://forums.adafruit.com/viewtopic.php?f=58&t=170634 |
@jepler I assume this CI failure is the same as ones that have been occurring for the past few days. Anything I need to do about it? |
@jerryneedell Would you mind rebasing this onto 6.0.x? That way it'll be fixed for 6.0.0 |
Sure -- How do I do that? |
OK -- I think I did that correctly. If not, let me know. |
But why does it now have all these other changes associated with it? |
PR is corrupted -- closing and will resubmit |
fixes #3582
tested on CPB with mini-tft featherwing.