Skip to content

Issue 3931 - Onboard LEDs lighting up due to wrong memset size in board_reset_user_neopixels() #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2021

Conversation

DavePutz
Copy link
Collaborator

@DavePutz DavePutz commented Jan 4, 2021

Fix for issue #3931. Looks like this issue popped up in commit 57101d7 where we started calling board_reset_user_neopixels() at startup. The memset size in that function was wrong; should be count *3 instead of count.

@DavePutz DavePutz changed the title Issue 3807 - Onboard LEDs lighting up due to wrong memset size in board_reset_user_neopixels() Issue 3931 - Onboard LEDs lighting up due to wrong memset size in board_reset_user_neopixels() Jan 4, 2021
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that sounds better :)

@dhalbert dhalbert merged commit 590fe8e into adafruit:main Jan 5, 2021
@jepler
Copy link

jepler commented Jan 5, 2021

@kattni can you close #3931 if this is fixed now?

@DavePutz DavePutz deleted the issue_3807 branch January 5, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants