Skip to content

Issue 3931 - Onboard LEDs lighting up due to wrong memset size in board_reset_user_neopixels() #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2021
Merged

Issue 3931 - Onboard LEDs lighting up due to wrong memset size in board_reset_user_neopixels() #3934

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d5c77c
Merge pull request #35 from adafruit/main
DavePutz Dec 10, 2020
9c14593
Merge pull request #36 from adafruit/main
DavePutz Dec 28, 2020
76e9f49
Merge pull request #37 from adafruit/main
DavePutz Jan 4, 2021
ce55822
Fix size of memset in board_reset_user_neopixels()
DavePutz Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion supervisor/shared/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
void board_reset_user_neopixels(const mcu_pin_obj_t* pin, size_t count) {
// Turn off on-board NeoPixel string
uint8_t empty[count * 3];
memset(empty, 0, count);
memset(empty, 0, count * 3);
digitalio_digitalinout_obj_t neopixel_pin;
common_hal_digitalio_digitalinout_construct(&neopixel_pin, pin);
common_hal_digitalio_digitalinout_switch_to_output(&neopixel_pin, false,
Expand Down