Skip to content

Added Sparkfun MicroMod RP2040 #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Added Sparkfun MicroMod RP2040 #4625

merged 3 commits into from
Apr 19, 2021

Conversation

stonehippo
Copy link

@stonehippo stonehippo commented Apr 17, 2021

Added board definition for the Sparkfun MicroMod RP2040.

Mostly followed the format for pins from the MicroMod nRF52840 board definition, as MicroMod tries to standardize pins across microcontrollers.

The MicroMod differs a bit from other SparkFun RP2040 boards in how it handles some pins (for example, it treats some pins as dedicated PWM or digital). To keep to the spirit of how the pins are defined in the datasheet, I have not mapped pins to a general Dx alias as was done with the SparkFun Pro Micro RP2040 and SparkFun Thing Plus RP2040 boards. The Gx format used by MicroMod is used for generic GPIO pins.

Added board definition for the Sparkfun MicroMod RP2040.

Mostly followed the format for pins from the MicroMod nRF52840 board
definition, as MicroMod tries to standardize pins across
microcontrollers.
@ladyada
Copy link
Member

ladyada commented Apr 17, 2021

hihi please run pylint/black or pre-commit on the files so CI passes and i'll take a look!

ladyada
ladyada previously approved these changes Apr 17, 2021
I missed a few pin definitions. Fixed those.
@stonehippo
Copy link
Author

@ladyada all CI checks passing now! Please review when you have a chance.

@ladyada
Copy link
Member

ladyada commented Apr 17, 2021

thanks, did Sparkfun give you taht PID to use? if not please ask them for a unique one so we can identify this board in circuitpython!

@stonehippo
Copy link
Author

I’m checking in their forum, will confirm when I hear back.

https://forum.sparkfun.com/viewtopic.php?f=182&t=55251

@tannewt
Copy link
Member

tannewt commented Apr 18, 2021

0x0024 is correct. I got them to assign USB PIDs up front and documented them here: #4042

@stonehippo
Copy link
Author

Thanks @tannewt! (I used the PID from that post, but wasn't sure how official it was). @ladyada anything else you need to review?

@ladyada ladyada merged commit b6fa90d into adafruit:main Apr 19, 2021
@ladyada
Copy link
Member

ladyada commented Apr 19, 2021

lgtm thank you for checking!

@stonehippo stonehippo deleted the sparkfun_micromod_atp_rp2040 branch April 19, 2021 03:03
Copy link

@zapwizard zapwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't figure out why I can't talk to a SPI display, D0 looks to be mapped wrong


STATIC const mp_rom_map_elem_t board_global_dict_table[] = {
// D (Digital only) pins (D0,D1)
{ MP_ROM_QSTR(MP_QSTR_D0), MP_ROM_PTR(&pin_GPIO7) }, // GPIO6 - D0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This calls out GPI07 twice (Comment looks like it should be GPIO6)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zapwizard Thanks for catching that. I've created #4665 to address it.

Not sure that should block connecting with SPI, though. Are you using the default definition? I'll take a look an make sure that's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants