Skip to content

Split displayio #8493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Split displayio #8493

merged 4 commits into from
Oct 25, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 20, 2023

These are moved:

  • Display -> busdisplay.BusDisplay
  • FourWire -> fourwire.FourWire
  • EPaperDisplay -> epaperdisplay.EPaperDisplay
  • I2CDisplay -> i2cdisplaybus.I2CDisplayBus

paralleldisplay is now paralleldisplaybus (and registered as
paralleldisplay too).

Bus related helpers are split out of display_core into bus_core.
It is in still displayio since it is a dependency of both
busdisplay and epaperdisplay.

Fixes #7667

This PR also fixes .root_group assignment. It was broken by a MP merge.

The PDF doc build now fails due to the size of the support matrix. So it is split out into its own PDF. The main PDF now has a dedicated root file docs/pdf.rst.

@tannewt tannewt requested a review from dhalbert October 20, 2023 21:50
@FoamyGuy
Copy link
Collaborator

I briefly tested the artifacts from this PR in 3 contexts:

  • Funhouse using print() to show messages on the display that was initialized automatically by default
  • Magtag using adafruit_display_text to show a label on the display at various locations
  • Matrix portal using some Bitmaps that have lines drawn within them, the display was initialized by adafruit_matrixportal library

All appeared to work as expected.

These are moved:
* Display -> busdisplay.BusDisplay
* FourWire -> fourwire.FourWire
* EPaperDisplay -> epaperdisplay.EPaperDisplay
* I2CDisplay -> i2cdisplaybus.I2CDisplayBus

`paralleldisplay` is now `paralleldisplaybus` (and registered as
`paralleldisplay` too).

Bus related helpers are split out of display_core into bus_core.
It is in still displayio since it is a dependency of both
busdisplay and epaperdisplay.

Fixes micropython#7667
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all the MP_TYPE_FLAG_HAS_SPECIAL_ACCESSORS!

I just have some CIRCUITPY-CHANGE changes and a few doc additions.

@tannewt
Copy link
Member Author

tannewt commented Oct 24, 2023

Updated! Sorry for the rebase.

@tannewt tannewt requested a review from dhalbert October 24, 2023 23:24
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit 702b4a5 into adafruit:main Oct 25, 2023
dhalbert pushed a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split displayio into displaycore, externalframebufferio, framebufferdisplayio and epaperdisplaypio (names TBD)
3 participants