-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Split displayio #8493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split displayio #8493
Conversation
I briefly tested the artifacts from this PR in 3 contexts:
All appeared to work as expected. |
These are moved: * Display -> busdisplay.BusDisplay * FourWire -> fourwire.FourWire * EPaperDisplay -> epaperdisplay.EPaperDisplay * I2CDisplay -> i2cdisplaybus.I2CDisplayBus `paralleldisplay` is now `paralleldisplaybus` (and registered as `paralleldisplay` too). Bus related helpers are split out of display_core into bus_core. It is in still displayio since it is a dependency of both busdisplay and epaperdisplay. Fixes micropython#7667
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing all the MP_TYPE_FLAG_HAS_SPECIAL_ACCESSORS
!
I just have some CIRCUITPY-CHANGE
changes and a few doc additions.
adf68ba
to
63079c7
Compare
Updated! Sorry for the rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
These are moved:
paralleldisplay
is nowparalleldisplaybus
(and registered asparalleldisplay
too).Bus related helpers are split out of display_core into bus_core.
It is in still displayio since it is a dependency of both
busdisplay and epaperdisplay.
Fixes #7667
This PR also fixes .root_group assignment. It was broken by a MP merge.
The PDF doc build now fails due to the size of the support matrix. So it is split out into its own PDF. The main PDF now has a dedicated root file
docs/pdf.rst
.