fix qt py esp32-s3 4/2 flash size and mode #8611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Nov 15, 2023
|
Erased flash and installed the |
|
Works once #8614 is reverted. Thanks Dan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8606.
I don't have this board to test but this change matches the datasheet. The flash size was wrong in any case.
diovsqiomay work either way, withdiojust being slower. There are many S3 boards withdio, so we should audit those.EDIT: also had to do -Os, as on the Feather, because it wouldn't fit. The flash size was wrong before so this was missed.