build_bundles: Ignore more packages that exist only on pypi #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and sort the existing list and use 'normalized' names The implementation of normalize_dist_name is taken from pipkin.
makermelissa
approved these changes
Jul 18, 2022
makermelissa
requested changes
Jul 18, 2022
This is a weird one since some devices have it in core now, and others don't. This happened in part because I copypasted the list currently in pipkin instead of tweaking the existing list, which was initially added with this module in the list: aivarannamaa/pipkin@b995713
makermelissa
approved these changes
Jul 18, 2022
|
To be clear -- is it OK if
? Do you know what exactly could this potential problem be? |
|
I'm not sure what that text means. From my understanding depending on the content of sys.path one will be preferred to the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and sort the existing list and use 'normalized' names
The implementation of normalize_dist_name is taken from pipkin. @aivarannamaa hopefully you can update this list once this PR is confirmed and merged.
@ladyada pipkin copies this list so we should make sure it's up to date on our end!
This list is based on all lines we list in a "requirements.txt" in the adafruit bundle, minutes the ones named adafruit-circuitpython-. Plus numpy and scipy which aren't actually USED at this time, but are added speculatively since dual-purpose code can work with ulab or with numpy.